hybrid retrieval #152
Merged
hybrid retrieval #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbertrand
force-pushed
the
hybrid_retrieval
branch
from
2782406
to
fee5fe2
Compare
jerpint
reviewed
Nov 16, 2023
jerpint
reviewed
Nov 17, 2023
jerpint
reviewed
Nov 17, 2023
jerpint
reviewed
Nov 17, 2023
hbertrand
force-pushed
the
hybrid_retrieval
branch
from
69d2587
to
64211c3
Compare
jerpint
reviewed
Nov 30, 2023
| @@ -33,7 +33,7 @@ class BusterConfig: | |||
| "max_tokens": 3000, | |||
| "top_k": 3, | |||
| "thresh": 0.7, | |||
| "embedding_model": "text-embedding-ada-002", | |||
| "embedding_fn": get_openai_embedding, | |||
There was a problem hiding this comment.
did you rebase / merge main? This should already be there at this point
There was a problem hiding this comment.
yes it's rebased. Not sure why it still shows this
There was a problem hiding this comment.
wait I checked main, we didn't do the change actually. Seems like a bug fix then :-)
jerpint
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.