Do not attempt to modify content if no global post is available #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `get_the_excerpt()` is called with an explicit `$post`, that post is passed as context to the `get_the_excerpt` filter. Even though `wp_trim_excerpt` receives the `$post` as an argument, it does not provide that as context when applying `the_content` to the post content. In this case, and probably other related cases, a fatal error would be generated because the global `$post` data we rely on is not available. A future commit may also account for a second parameter passed to `the_content`, but I'll think that through some more. :) See #44
aaronjorbin
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
get_the_excerpt()is called with an explicit$post, that post is passed as context to theget_the_excerptfilter.Even though
wp_trim_excerptreceives the$postas an argument, it does not provide that as context when applyingthe_contentto the post content.In this case, and probably other related cases, a fatal error would be generated because the global
$postdata we rely on is not available.A future commit may also account for a second parameter passed to
the_content, but I'll think that through some more. :)See #44