feat(sdk): Implement Chitchatter SDK #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mephraim
reviewed
Oct 24, 2023
sdk/sdk.ts
Outdated
| window.removeEventListener('message', handleMessageReceived) | ||
| } | ||
|
|
||
| window.addEventListener('message', handleMessageReceived) |
There was a problem hiding this comment.
Since you're adding an event listener to the window, you may want to add a disconnectedCallback that removes the event listener and clears the timer if the component gets removed from the DOM before a message is received.
Otherwise, there's a possibility that the timer or the event handler will retain the component in memory, even if it has been removed from the DOM.
There was a problem hiding this comment.
Great catch. This is fixed in 75cfca6!
There was a problem hiding this comment.
Followup fix in b4fa41a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Chitchatter SDK for embedding Chitchatter instances into web apps with configuration options beyond the standard
<iframe />method. It can be used like so (once merged and deployed):