refactor(sdk): use map for chat room attributes

jeremyckahn · Oct 24, 2023 · fbd1844 · fbd1844
1 parent bd8cf39
commit fbd1844
Showing 1 changed file with 20 additions and 3 deletions.
diff --git a/src/pages/Home/EmbedCodeDialog.tsx b/src/pages/Home/EmbedCodeDialog.tsx
@@ -29,12 +29,29 @@ export const EmbedCodeDialog = ({
 
   const needsRootUrlAttribute = window.location.origin !== homepageUrl.origin
 
+  const chatRoomAttributes: {
+    room: string
+    ['root-url']?: string
+    width: string
+    height: string
+  } = {
+    room: roomName,
+    width: '800',
+    height: '800',
+  }
+
+  if (needsRootUrlAttribute) {
+    chatRoomAttributes['root-url'] = `${window.location.origin}/`
+  }
+
+  const attributesString = Object.entries(chatRoomAttributes)
+    .map(([key, value]) => `${key}=${value}`)
+    .join(' ')
+
   // NOTE: The script src is inaccurate in the local development environment.
   const sdkEmbedCode = `<script src="${window.location.origin}/sdk.js"></script>
 
-<chat-room room="${roomName}" ${
-    needsRootUrlAttribute ? `root-url="${window.location.origin}/" ` : ''
-  }width="800" height="800" />`
+<chat-room ${attributesString} />`
 
   return (
     <Dialog open={showEmbedCode} onClose={handleEmbedCodeWindowClose}>