Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #115

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Update tests #115

merged 1 commit into from
Jan 22, 2024

Conversation

teunbrand
Copy link
Contributor

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break scdhlm.

Briefly, we've updated the result object from ggplot(), which broke some tests that assumed equility in some plot components. This PR exclude some of the new items from the test of equality.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help scdhlm get out a fix if necessary.

@jepusto jepusto merged commit 78447c2 into jepusto:main Jan 22, 2024
9 checks passed
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch January 22, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants