Extract numbers generation into separate class #19
Conversation
| @@ -11,12 +11,12 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=5.4.0" | |||
| "php": ">=5.4.0", | |||
| "phpseclib/phpseclib": "^2.0", | |||
There was a problem hiding this comment.
I don't really like having these dependencies here though. I want this library to be used in any application and this might conflict with application dependencies.
Maybe it's best to move these back to dev and add a suggests part + mention it in the readme that if people want to use Energon they have to include these dependencies.
There was a problem hiding this comment.
I've reverted the composer.json changes and left any README changes up to you. This way you can mention it how it suits you best.
I'd like to point out though that the phpseclib dependency is currently required to run the old/current spark command, without any note in the README. It could be viable to move the dependency notification up to that readme section?
|
Added tests as well for the new Energon class. |
|
Any updates on this? |
|
@jenssegers Could you review this please? |
|
Sorry that this took so long. Merged and tagged! |
As suggested previously in #9 .
Derived packages can as such use a consistent number generation logic instead of needing to define it themselves.
Since this package already includes "Optimus" and its life essence "Spark", I thought "Energon" (Transformer's fuel) would be a great addition :-)
Note that the
optimusphar still needs to be rebuilt.