Skip to content

Commit

Permalink
Revert timeout back 2000ms instead of 1200000ms in TransportManager.j…
Browse files Browse the repository at this point in the history
…ava (#210)

Recent  change to timeout be causing some SSH sessions, to timeout because of inactivity.

Commands that worked without issues in our enviroment previously but not anylonger:
sleep 120s
but it was working fine with:
asynchronousQueue.wait(2000);
but not with the new:
asynchronousQueue.wait(DEFAULT_WAIT_TIMEOUT); //1200000ms

Notice the even the comment was left: /* After the queue is empty for about 2 seconds, stop this thread */
I think it was a mistake to change this specific wait() with to a different timeout.
as the pullrequest seems to want to introduce a default timeout to the wait() with infinite timeouts. 


15622af#diff-fbe5f13c040cb16dee69517cb436e446fa38cfb3262e690cc711f52a32edda75R92
  • Loading branch information
Elisedlund-ericsson authored Nov 18, 2024
1 parent ff104d2 commit 882177e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/com/trilead/ssh2/transport/TransportManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public void run()

try
{
asynchronousQueue.wait(DEFAULT_WAIT_TIMEOUT);
asynchronousQueue.wait(2000);
}
catch (InterruptedException e)
{
Expand Down

0 comments on commit 882177e

Please sign in to comment.