Skip to content

Commit

Permalink
Migrate from EE 8 to EE 9 (#203)
Browse files Browse the repository at this point in the history
  • Loading branch information
basil authored Feb 5, 2025
1 parent a319fc3 commit 69c8f4c
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 18 deletions.
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>4.88</version>
<version>5.5</version>
<relativePath />
</parent>

Expand Down Expand Up @@ -33,8 +33,8 @@
<revision>3</revision>
<changelist>999999-SNAPSHOT</changelist>
<!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
<jenkins.baseline>2.440</jenkins.baseline>
<jenkins.version>${jenkins.baseline}.3</jenkins.version>
<jenkins.baseline>2.479</jenkins.baseline>
<jenkins.version>${jenkins.baseline}.1</jenkins.version>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
</properties>

Expand All @@ -43,7 +43,7 @@
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-${jenkins.baseline}.x</artifactId>
<version>3413.v0d896b_76a_30d</version>
<version>3850.vb_c5319efa_e29</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/jenkinsci/main/modules/sshd/SSHD.java
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
import org.apache.sshd.server.SshServer;
import org.apache.sshd.server.auth.UserAuthFactory;
import org.jenkinsci.main.modules.instance_identity.InstanceIdentity;
import org.kohsuke.stapler.StaplerRequest;
import org.kohsuke.stapler.StaplerRequest2;

/**
* @author Kohsuke Kawaguchi
Expand Down Expand Up @@ -240,7 +240,7 @@ public synchronized void stop() throws IOException, InterruptedException {
}

@Override
public boolean configure(StaplerRequest req, JSONObject json) throws FormException {
public boolean configure(StaplerRequest2 req, JSONObject json) throws FormException {
setPort(new ServerTcpPort(json.getJSONObject("port")).getPort());
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ package org.jenkinsci.main.modules.sshd.PortAdvertiser;

def v = my.endpoint;
if (v!=null)
response.addHeader("X-SSH-Endpoint",v);
response2.addHeader("X-SSH-Endpoint",v);
22 changes: 11 additions & 11 deletions src/test/java/org/jenkinsci/main/modules/cli/auth/ssh/CLITest.java
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@
import org.kohsuke.stapler.HttpResponses.HttpResponseException;
import org.kohsuke.stapler.Stapler;
import org.kohsuke.stapler.StaplerProxy;
import org.kohsuke.stapler.StaplerRequest;
import org.kohsuke.stapler.StaplerResponse;
import org.kohsuke.stapler.StaplerRequest2;
import org.kohsuke.stapler.StaplerResponse2;

import javax.servlet.FilterChain;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import jakarta.servlet.FilterChain;
import jakarta.servlet.ServletException;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -234,11 +234,11 @@ public static final class NoJenkinsAction extends CrumbExclusion implements Unpr
}

@Override public Object getTarget() {
doDynamic(Stapler.getCurrentRequest(), Stapler.getCurrentResponse());
doDynamic(Stapler.getCurrentRequest2(), Stapler.getCurrentResponse2());
return this;
}

public void doDynamic(StaplerRequest req, StaplerResponse rsp) {
public void doDynamic(StaplerRequest2 req, StaplerResponse2 rsp) {
rsp.setStatus(200);
}

Expand Down Expand Up @@ -297,15 +297,15 @@ public static final class CliProxyAction extends CrumbExclusion implements Unpro
}

@Override public Object getTarget() {
throw doDynamic(Stapler.getCurrentRequest(), Stapler.getCurrentResponse());
throw doDynamic(Stapler.getCurrentRequest2(), Stapler.getCurrentResponse2());
}

public HttpResponseException doDynamic(StaplerRequest req, StaplerResponse rsp) {
public HttpResponseException doDynamic(StaplerRequest2 req, StaplerResponse2 rsp) {
final String url = req.getRequestURIWithQueryString().replaceFirst("/cli-proxy", "");
// Custom written redirect so no traces of Jenkins are present in headers
return new HttpResponseException() {
@Override
public void generateResponse(StaplerRequest req, StaplerResponse rsp, Object node) throws IOException, ServletException {
public void generateResponse(StaplerRequest2 req, StaplerResponse2 rsp, Object node) throws IOException, ServletException {
rsp.setHeader("Location", url);
rsp.setContentType("text/html");
rsp.setStatus(HttpURLConnection.HTTP_MOVED_TEMP);
Expand Down

0 comments on commit 69c8f4c

Please sign in to comment.