Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobAndRunAPITest: Unit Test do not work on Windows - fix #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

JobAndRunAPITest: Unit Test do not work on Windows - fix #51

wants to merge 1 commit into from

Conversation

KrzysztofDziankowski
Copy link

Test testDuration0EdgeCase in JobAndRunAPITest use Jenkinsfile with "sh" tags. Those tags do not work (out of the box) on Windows. More over looks like there is no need to use "sh". I changed it to "echo".

alexanderrtaylor
alexanderrtaylor approved these changes Apr 28, 2020
View reviewed changes
Copy link

@alexanderrtaylor alexanderrtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah doing an echo instead of a sleep would be fine and if it passes with windows tests then lets do it(especially with the new windows test expectations which have not hit OSS Jenkins but are running in CB plugins)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderrtaylor alexanderrtaylor alexanderrtaylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KrzysztofDziankowski @alexanderrtaylor