Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing tls key for insecure configuration #205

Merged
merged 1 commit into from
Nov 8, 2021
Merged

missing tls key for insecure configuration #205

merged 1 commit into from
Nov 8, 2021

Conversation

shurikg
Copy link
Contributor

@shurikg shurikg commented Nov 7, 2021

Missing the "tls" section for jaeger and elastic in otel-configuration.yaml demo file.

kuisathaverat
kuisathaverat approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@kuisathaverat kuisathaverat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the Otel collector Documentation was fixed a month ago too

https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/otlphttpexporter/README.md

@v1v
Copy link
Member

v1v commented Nov 8, 2021

Thanks for the PR! LGTM.

I'm gonna test it locally

@cyrille-leclerc
Copy link
Contributor

good catch, new otel collector config.

@v1v v1v added the documentation Improvements or additions to documentation label Nov 8, 2021
@v1v v1v merged commit ef1730f into jenkinsci:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrille-leclerc cyrille-leclerc cyrille-leclerc approved these changes

@v1v v1v v1v approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@shurikg shurikg

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shurikg @v1v @cyrille-leclerc @kuisathaverat