Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about not being logged in on 404 error page #9766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-beck
Copy link
Member

@daniel-beck daniel-beck commented Sep 20, 2024

A recent comment in https://issues.jenkins.io/browse/JENKINS-21813 (which IMO was taken care of by #8250) brought up that it's not really easy to tell you're not logged in, just a difference in the header.

So this makes that more obvious. Suggestions for wording welcome.

Testing done

Before

https://ci.jenkins.io/lol

After

Screenshot 2024-09-20 at 20 09 15

Proposed changelog entries

Too minor?

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added the skip-changelog Should not be shown in the changelog label Sep 22, 2024
@timja
Copy link
Member

timja commented Sep 22, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants