Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73801] Nested Views plugin overrides View#doConfigDotXml(StaplerRequest) #9764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

basil
Copy link
Member

@basil basil commented Sep 20, 2024

See JENKINS-73801. (Very) minor flaw in the EE 9 compatibility layer: the overridden View#doConfigDotXml(StaplerRequest) method was no longer called as of 2.475.

Testing done

Created a Nested View and viewed its config.xml in the UI in 2.474, 2.475, and this PR. In 2.475 the overridden method was not called and I saw output from the superclass method (without owner); in 2.474 and with this PR the overridden method was called and I saw output from the overridden method (with owner).

Proposed changelog entries

Restore compatibility with plugins contributing new views with custom XML, like Nested Views plugin.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Sep 20, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants