Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow idiomatic Python coding style #9763

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

basil
Copy link
Member

@basil basil commented Sep 19, 2024

Amends #7240 to follow idiomatic Python coding style.

Testing done

Ran "CI" in os.environ in an interactive Python 3 shell both with and without the environment variable defined.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the skip-changelog Should not be shown in the changelog label Sep 19, 2024
@@ -102,8 +102,8 @@ def analyze_files(commits_and_tags, dry_run=False):
"*.js",
]

runningInCI = os.environ.get("CI", "false") == "true"
if runningInCI:
is_ci = "CI" in os.environ
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basil
Copy link
Member Author

basil commented Sep 20, 2024

De minimis

@basil basil merged commit 57d8fa0 into jenkinsci:master Sep 20, 2024
15 checks passed
@basil basil deleted the pythonic branch September 20, 2024 15:23
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants