-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-71021] Lint failures do not print proper error message in local builds (regression in 2.359) #9761
Conversation
…cal builds (regression in 2.359)
<execution> | ||
<id>yarn lint</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear why there were three linting executions; there is only a need for two (one for CI, and one for local builds). Deleted the unnecessary execution and moved the two necessary executions to the correct place in the file (after the build executions, reflecting the order of operations at runtime).
<goals> | ||
<goal>yarn</goal> | ||
</goals> | ||
<phase>test</phase> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed in order to get CI builds to honor
Line 96 in 57d8fa0
'-Dmaven.test.failure.ignore', |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
See JENKINS-71021.
Amending the Maven profile changes from #9718 which appear to have been completely untested prior to integration.
Testing done
Introduced stylelint and eslint failures in both CI and local builds.
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist