Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73771] do not lose the formField in the response #9729

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Sep 13, 2024

Implements a crude way to not lose the important part that is the form field.

This is a quick and dirty approach, a complete fix should also take into account the describable being bound as in a nested page like /manage/configure a field name may not even be unique or provide enough context due to localization.

However for now this makes the situation less bad without introducing debt.

See JENKINS-73771.

Testing done

Proposed changelog entries

  • human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Implements a crude way to not loose the important part that is the form
field.

This is a quick and dirty approach, a complete fix should also take into
account the describable being bound as in a nested page like
/manage/configure a field name may not even be unique.

However for now this makes the situation less bad without introducing
debt.
@MarkEWaite MarkEWaite changed the title [JENKINS-73771] do not loose the formField in the response [JENKINS-73771] do not lose the formField in the response Sep 13, 2024
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Oct 21, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unresolved-merge-conflict There is a merge conflict with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant