Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a discussion with @jonesbusy in jenkinsci/custom-folder-icon-plugin#387 I stumbled upon custom-job-icon-plugin which by now has become deprecated / out-dated but brought up the interesting idea of being able to change the default icon of a
Job
from theBallColor
to something else similar as custom-folder-icon-plugin already does it forAbstractFolder
.Since I really liked the idea and already have a use case myself I wanted to bring this to the core to lay the foundation.
Once this is done I'd like to adopt the
custom-job-icon-plugin
and build up on it.This PR introduces the
icon
field of typeJobIcon
to a Job. It is used in the relevant*.jelly
files of the core to visualize a Job and by default relies on a new implementationBuildStatusIcon
.A
Job
now has a configuration for itsicon
. Overall the implementation is very similar to the approach of cloudbees-folder-plugin.Screenshots:
Main View
Job Overview
Configuration
Full disclaimer, I am aware that this draft is still a little rough on the edges how ever to see if this goes anywhere I'd be grateful for some feedback.
Testing done
Only manual testing so far, tests to follow in case we want to follow up on this draft.
For testing purposes I also included the
TestIcon
class to have something to work with other than the default.Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
N/A
Before the changes are marked as
ready-for-merge
:Maintainer checklist