-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add null alt text to several images #9296
Open
JanhviHarwani
wants to merge
20
commits into
jenkinsci:master
Choose a base branch
from
JanhviHarwani:feature/add-null-text-alt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−10
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7c874c4
Merge pull request #1 from jenkinsci/master
JanhviHarwani 08fc4b7
Added alt attribute to all img tag
janhvi-simform 4a2c910
Added null as text in alt attribute
janhvi-simform 8cf6508
Merge pull request #2 from jenkinsci/master
JanhviHarwani 6d4fa24
Merge branch 'master' of https://github.com/JanhviHarwani/jenkins int…
janhvi-simform c7867b2
Merge pull request #3 from jenkinsci/master
JanhviHarwani 4d8fd42
Resolved all the PR comments
janhvi-simform 9eafafe
Merge branch 'feature/add-null-text-alt' of https://github.com/Janhvi…
janhvi-simform e16257d
Updated alt image messages for dir.jelly, _404_simple.jelly and execu…
janhvi-simform 1b731b5
Merge branch 'master' into feature/add-null-text-alt
daniel-beck 6275984
Merge branch 'master' into feature/add-null-text-alt
MarkEWaite b782620
Do not attempt to localize Jenkins welcome page alt text
MarkEWaite 87d4ab4
More clearly describe the participate link
MarkEWaite 904cb3e
Internationalize memory usage monitor graph
MarkEWaite 8d861dd
Use empty alt text when immediately followed by text
MarkEWaite 690501b
Use empty alt text in dropdown documentation example
MarkEWaite 23d56f1
Use empty alt text because nearby text already has the message
MarkEWaite f110180
Use empty alt text - nearby text already provides details
MarkEWaite 1806b45
Merge branch 'master' into feature/add-null-text-alt
MarkEWaite 42f2883
Merge branch 'master' into feature/add-null-text-alt
MarkEWaite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent with the change in
_404_simple.jelly
, why?(Personally I like this one more for the same reason as I mentioned in a number of other comments.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 23d56f1 by using empty alt text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not true, this is the only line in this PR you didn't update 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that. This was resolved in 4d8fd42