Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the appearance of the stop button #8780

Merged
merged 11 commits into from
Dec 20, 2023

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Dec 13, 2023

Small MR to update the appearance of the stop button component.

Before
image
image
image

After
image
image
image

Testing done

  • Component works as before, doesn't cause layout shifts

Proposed changelog entries

  • Update the appearance of the stop button.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks good, Thanks!

One localization is broken now.

@@ -126,7 +126,7 @@ THE SOFTWARE.
</st:include>
<td class="pane" align="center" valign="middle">
<j:if test="${h.hasPermission(exeparent,exeparent.READ) and e.hasStopPermission()}">
<l:stopButton href="${rootURL}/${c.url}${url}/stopBuild?runExtId=${h.urlEncode(exe.externalizableId)}" confirm="${%confirm(exe.fullDisplayName)}" alt="${%terminate this build}" />
<l:stopButton href="${rootURL}/${c.url}${url}/stopBuild?runExtId=${h.urlEncode(exe.externalizableId)}" confirm="${%confirm(exe.fullDisplayName)}" alt="${%Cancel}" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the i18n, it would be better to use Cancel in the properties as {en} translation. Or rename all translations.

@NotMyFault NotMyFault added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted needs-security-review Awaiting review by a security team member needs-ath-build Needs to run through the full acceptance-test-harness suite needs-test-fix One or more test case(s) need to be updated labels Dec 14, 2023
@NotMyFault NotMyFault requested review from a team December 14, 2023 20:34
@timja
Copy link
Member

timja commented Dec 15, 2023

Tests failing

@timja timja removed the needs-test-fix One or more test case(s) need to be updated label Dec 16, 2023
CI build is too unreliable and I just want an incrementals...
@timja timja added ath-successful This PR has successfully passed the full acceptance-test-harness suite and removed needs-ath-build Needs to run through the full acceptance-test-harness suite labels Dec 17, 2023
Copy link
Contributor

@yaroslavafenkin yaroslavafenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK security wise.


image
Is it just me or alignment is off? Nor aligned with the progress bar, neither with #1.

@yaroslavafenkin yaroslavafenkin added security-approved @jenkinsci/core-security-review reviewed this PR for security issues and removed needs-security-review Awaiting review by a security team member labels Dec 19, 2023
@daniel-beck
Copy link
Member

alignment is off

Not newly introduced per screenshots in PR comment.

@timja
Copy link
Member

timja commented Dec 19, 2023

alignment is off

Not newly introduced per screenshots in PR comment.

similar-ish things noticed here:
#8761 (review)

a few things looking a bit funny but they were already in that state.

@timja
Copy link
Member

timja commented Dec 19, 2023

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 19, 2023
@NotMyFault NotMyFault merged commit 01c42a3 into jenkinsci:master Dec 20, 2023
17 checks passed
@timja timja deleted the stop-button branch December 20, 2023 22:41
@DuMaM
Copy link
Contributor

DuMaM commented Dec 29, 2023

Thanks :D I was waiting so long for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ath-successful This PR has successfully passed the full acceptance-test-harness suite ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants