-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the appearance of the stop button #8780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI looks good, Thanks!
One localization is broken now.
@@ -126,7 +126,7 @@ THE SOFTWARE. | |||
</st:include> | |||
<td class="pane" align="center" valign="middle"> | |||
<j:if test="${h.hasPermission(exeparent,exeparent.READ) and e.hasStopPermission()}"> | |||
<l:stopButton href="${rootURL}/${c.url}${url}/stopBuild?runExtId=${h.urlEncode(exe.externalizableId)}" confirm="${%confirm(exe.fullDisplayName)}" alt="${%terminate this build}" /> | |||
<l:stopButton href="${rootURL}/${c.url}${url}/stopBuild?runExtId=${h.urlEncode(exe.externalizableId)}" confirm="${%confirm(exe.fullDisplayName)}" alt="${%Cancel}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the i18n, it would be better to use Cancel in the properties as {en} translation. Or rename all translations.
Tests failing |
CI build is too unreliable and I just want an incrementals...
This reverts commit 28df839.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not newly introduced per screenshots in PR comment. |
similar-ish things noticed here: a few things looking a bit funny but they were already in that state. |
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Thanks :D I was waiting so long for this change. |
Small MR to update the appearance of the stop button component.
Before
After
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist