Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Woodstox from WAR #5651

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Remove Woodstox from WAR #5651

merged 1 commit into from
Aug 12, 2021

Conversation

basil
Copy link
Member

@basil basil commented Aug 2, 2021

The tasks in #5604 (comment) have been completed, so #5604 can be reverted:

Testing done

  • Ran java -jar jenkins.war and installed the default plugin list and the Azure Storage plugin.
  • Started the Azurite storage emulator with docker run -p 10000:10000 -p 10001:10001 -p 10002:10002 mcr.microsoft.com/azure-storage/azurite.
  • Went to http://127.0.0.1:8080/credentials/store/system/domain/_/newCredentials and added a new Azure Storage credential with account name, devstoreaccount1, account key Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==, and URL http://127.0.0.1:10000/devstoreaccount1/.
  • Clicked Verify Configuration and confirmed that the "Validation successful" message was printed.

Proposed changelog entries

Removed: The Woodstox implementation of the StAX API has been removed from Jenkins core. Users of the Azure Artifact Manager, Azure Container Agents, Azure Storage, and Azure SDK API plugins must upgrade those plugins to the latest versions in lockstep with this core upgrade. Plugins that consume Woodstox should depend on it directly or via the Jackson 2 API plugin.

Proposed upgrade guidelines

The Woodstox implementation of the StAX API has been removed from Jenkins core. Users of the Azure Artifact Manager, Azure Container Agents, Azure Storage, and Azure SDK API plugins must upgrade those plugins to the latest versions in lockstep with this core upgrade. Plugins that consume Woodstox should depend on it directly or via the Jackson 2 API plugin.

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@basil basil added the removed This PR removes a feature or a public API label Aug 2, 2021
@timja timja requested a review from a team August 2, 2021 18:57
@daniel-beck daniel-beck added the upgrade-guide-needed This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed label Aug 3, 2021
@daniel-beck
Copy link
Member

Looks reasonable, thanks for taking care of this 👍

I suggest the changelog entry be rephrased, instead of

the latest versions in lockstep

it should specify the versions to use to make it easier to confirm you're on what's needed; especially once it's a few weeks later and newer (but unnecessary) plugin releases are out.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from me. Time to start the countdown?

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 6, 2021
@timja
Copy link
Member

timja commented Aug 6, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback removed This PR removes a feature or a public API upgrade-guide-needed This changes might be breaking in rare circumstances, an entry in the LTS upgrade guide is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants