Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-75174] Move existing web.xml to web-fragment.xml under core #10185

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jan 21, 2025

As this impacts only EOM integrators (CloudBees), I deliberately omitted changelog. Please let me know if you think otherwise.

Noting that plugins using a Jenkins version including this change will need to use the jth version mentioned above or later.

See JENKINS-75174.

Testing done

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@Vlatombe Vlatombe added skip-changelog Should not be shown in the changelog developer Changes which impact plugin developers labels Jan 21, 2025
@Vlatombe Vlatombe requested a review from jglick January 21, 2025 13:31
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jan 21, 2025
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@timja
Copy link
Member

timja commented Jan 22, 2025

Noting that plugins using a Jenkins version including this change will need to use the jth version mentioned above or later.

Does this affect PCT? i.e is a bom build needed?

@Vlatombe
Copy link
Member Author

Vlatombe commented Jan 22, 2025

is a bom build needed ?

Yes, I will need a patch on pct repo as well to pick up jenkinsci/jenkins-test-harness#899

test/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pity that Git rename detection fails when you keep a relatively unrelated file under the original name.

test/pom.xml Outdated Show resolved Hide resolved
@github-actions github-actions bot added unresolved-merge-conflict There is a merge conflict with the target branch. and removed unresolved-merge-conflict There is a merge conflict with the target branch. labels Jan 23, 2025
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jan 24, 2025
@Vlatombe
Copy link
Member Author

This change would need a BOM build with jenkinsci/plugin-compat-tester#746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants