-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-75174] Move existing web.xml
to web-fragment.xml
under core
#10185
base: master
Are you sure you want to change the base?
Conversation
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Does this affect PCT? i.e is a bom build needed? |
Yes, I will need a patch on pct repo as well to pick up jenkinsci/jenkins-test-harness#899 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pity that Git rename detection fails when you keep a relatively unrelated file under the original name.
Please take a moment and address the merge conflicts of your pull request. Thanks! |
This change would need a BOM build with jenkinsci/plugin-compat-tester#746 |
As this impacts only EOM integrators (CloudBees), I deliberately omitted changelog. Please let me know if you think otherwise.
test
module successful.Noting that plugins using a Jenkins version including this change will need to use the jth version mentioned above or later.
See JENKINS-75174.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist