Hosting 808 #151
Merged
Hosting 808 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syndbg
approved these changes
Jul 26, 2019
|
We're using it for a while now and this is a building and working version compared to the one in master. |
|
A per the title, this is not quite ready for a merge, we need to address all of the issues in HOSTING-808 in Jenkins JIRA. I’m travelling and don’t have equipment with me bar my phone :) At minimum we need to address the permission check note, before this can be merged. If you have the time a P.R. against this would be most welcome. |
added 2 commits
August 4, 2019 05:12
|
See #150 for some more notes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to begin addressing issues in https://issues.jenkins-ci.org/browse/HOSTING-808
After the parent version bump, this seems to be building well now.
If you want to test it, check this branch out and;
Grab the
.hpithat is produced, and install using the "Advanced" option in plugin administration section.