Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(updatecli): remove docker compose target from manifests #430

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 19, 2024

This PR removes docker compose target from updatecli manifests as build-windows.yaml has been removed in #415.

Fixup of:

Testing done

$ updatecli diff --values updatecli/values.github-action.yaml --values updatecli/values.temurin.yaml --config updatecli/updatecli.d/

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lemeurherve lemeurherve requested a review from a team as a code owner June 19, 2024 16:37
@lemeurherve lemeurherve enabled auto-merge (squash) June 19, 2024 16:37
@lemeurherve lemeurherve disabled auto-merge June 19, 2024 17:08
@lemeurherve
Copy link
Member Author

Merging without waiting for the complete image build, already confirmed working: https://ci.jenkins.io/job/Packaging/job/docker-ssh-agent/job/master/444/

@lemeurherve lemeurherve merged commit d1bfd81 into jenkinsci:master Jun 19, 2024
2 of 3 checks passed
@lemeurherve lemeurherve deleted the hotfix-bake-updatecli branch June 19, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants