-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve env var scopes and retrieve VERSION
in build.ps1
#424
Merged
lemeurherve
merged 4 commits into
jenkinsci:master
from
lemeurherve:issue423-improve-env-vars-scope
Jun 18, 2024
Merged
chore: improve env var scopes and retrieve VERSION
in build.ps1
#424
lemeurherve
merged 4 commits into
jenkinsci:master
from
lemeurherve:issue423-improve-env-vars-scope
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
previously approved these changes
Jun 10, 2024
lemeurherve
force-pushed
the
issue423-improve-env-vars-scope
branch
from
June 10, 2024 10:56
c990be7
to
237f698
Compare
lemeurherve
changed the title
chore: improve environment variable scopes
chore: improve environment variable scopes and retrieval of Jun 10, 2024
VERSION
as env var in build.ps1
6 tasks
lemeurherve
changed the title
chore: improve environment variable scopes and retrieval of
chore: improve environment variable scopes and retrieve of Jun 10, 2024
VERSION
as env var in build.ps1VERSION
as env var in build.ps1
lemeurherve
changed the title
chore: improve environment variable scopes and retrieve of
chore: improve environment variable scopes and retrieve Jun 10, 2024
VERSION
as env var in build.ps1VERSION
as env var in build.ps1
lemeurherve
changed the title
chore: improve environment variable scopes and retrieve
chore: improve env var scopes and retrieve Jun 10, 2024
VERSION
as env var in build.ps1VERSION
as env var in build.ps1
timja
previously approved these changes
Jun 10, 2024
lemeurherve
force-pushed
the
issue423-improve-env-vars-scope
branch
from
June 10, 2024 11:15
237f698
to
a44d3c9
Compare
So sorry @timja just noticed your new review after repushing to remove the dangling |
timja
previously approved these changes
Jun 10, 2024
This was referenced Jun 15, 2024
lemeurherve
changed the title
chore: improve env var scopes and retrieve
chore: improve env var scopes and retrieve Jun 18, 2024
VERSION
as env var in build.ps1VERSION
in build.ps1
dduportal
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves environment variable scopes, allows retrieving
VERSION
from env var in build.ps1 so it can benefits the new scoping, and shortensagentSelector
comments in the Jenkinsfile.By doing so, it removes any interpolation in the last
sh
andpowershell
code blocks.Fixes:
Extracted from:
Testing done
CI
Submitter checklist