Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve env var scopes and retrieve VERSION in build.ps1 #424

Merged

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jun 10, 2024

This PR improves environment variable scopes, allows retrieving VERSION from env var in build.ps1 so it can benefits the new scoping, and shortens agentSelector comments in the Jenkinsfile.

By doing so, it removes any interpolation in the last sh and powershell code blocks.

Fixes:

Extracted from:

Testing done

CI

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lemeurherve lemeurherve requested a review from a team as a code owner June 10, 2024 10:47
timja
timja previously approved these changes Jun 10, 2024
@lemeurherve lemeurherve force-pushed the issue423-improve-env-vars-scope branch from c990be7 to 237f698 Compare June 10, 2024 10:56
@lemeurherve lemeurherve changed the title chore: improve environment variable scopes chore: improve environment variable scopes and retrieval of VERSION as env var in build.ps1 Jun 10, 2024
@lemeurherve lemeurherve changed the title chore: improve environment variable scopes and retrieval of VERSION as env var in build.ps1 chore: improve environment variable scopes and retrieve of VERSION as env var in build.ps1 Jun 10, 2024
@lemeurherve lemeurherve changed the title chore: improve environment variable scopes and retrieve of VERSION as env var in build.ps1 chore: improve environment variable scopes and retrieve VERSION as env var in build.ps1 Jun 10, 2024
@lemeurherve lemeurherve changed the title chore: improve environment variable scopes and retrieve VERSION as env var in build.ps1 chore: improve env var scopes and retrieve VERSION as env var in build.ps1 Jun 10, 2024
@lemeurherve lemeurherve requested review from timja and a team June 10, 2024 11:09
timja
timja previously approved these changes Jun 10, 2024
@lemeurherve
Copy link
Member Author

lemeurherve commented Jun 10, 2024

So sorry @timja just noticed your new review after repushing to remove the dangling -VersionTag in the last buid.ps1 call 😓

@lemeurherve lemeurherve marked this pull request as draft June 10, 2024 11:19
@lemeurherve lemeurherve marked this pull request as ready for review June 10, 2024 11:20
timja
timja previously approved these changes Jun 10, 2024
@lemeurherve lemeurherve requested a review from dduportal June 18, 2024 10:25
@lemeurherve lemeurherve changed the title chore: improve env var scopes and retrieve VERSION as env var in build.ps1 chore: improve env var scopes and retrieve VERSION in build.ps1 Jun 18, 2024
@lemeurherve lemeurherve requested a review from a team June 18, 2024 16:02
@lemeurherve lemeurherve enabled auto-merge (squash) June 18, 2024 16:28
@lemeurherve lemeurherve merged commit 3b45fbd into jenkinsci:master Jun 18, 2024
9 checks passed
@lemeurherve lemeurherve deleted the issue423-improve-env-vars-scope branch June 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants