Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli) track bats version #345

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Nov 13, 2023

Follow up of #344, this PR introduces an updatecli manifest to track the version of bats.

Testing done

  • Ran the command updatecli diff --values ./updatecli/values.github-action.yaml --config ./updatecli/updatecli.d/bats.yaml locally which succeded with "no changes"
  • Tried to change (locally) the bats version to v1.7.0: the command updatecli diff --values ./updatecli/values.github-action.yaml --config ./updatecli/updatecli.d/bats.yaml (with target's scmid commented out) proposed to bump v1.7.0 to v1.10.0 in the `Makefile as expected
  • CI check reports a success as well:
✔ Bump `bats` version:
	Source:
		✔ [lastVersion] 
	Target:
		✔ [updateMakefile] Updates `bats` version in the Makefile

@dduportal dduportal marked this pull request as ready for review November 13, 2023 17:24
@dduportal dduportal requested a review from a team as a code owner November 13, 2023 17:24
@MarkEWaite MarkEWaite merged commit 0e5a76e into jenkinsci:master Nov 13, 2023
3 checks passed
@dduportal dduportal deleted the chore/updatecli/bats branch November 13, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants