Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74056] Extract JS in PipelineHeaderExtension/columnHeader.jelly #148

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

shlomomdahan
Copy link

@shlomomdahan shlomomdahan commented Oct 31, 2024

JENKINS-74056

Similar Extraction - used as reference

To test:

  1. Create a pipeline similar to [JENKINS-73960] Extract event handlers in BuildCardExtension/buildCardTemplate.jelly #142
  2. In the pipeline configuration settings, use the below setting to reveal the column Header cards.
    Screenshot 2024-10-31 at 2 44 12 PM

You should see the cards above the pipeline:
Screenshot 2024-10-31 at 2 44 35 PM

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@shlomomdahan shlomomdahan requested a review from a team as a code owner October 31, 2024 18:45
@shlomomdahan shlomomdahan mentioned this pull request Nov 4, 2024
6 tasks
@basil
Copy link
Member

basil commented Nov 8, 2024

Can we split the negative ID bugfix into a separate PR so that I can review that independently of the CSP changes?

@shlomomdahan
Copy link
Author

@basil

PR for negative ID bugfix created: #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants