[JENKINS-73961] Extract event handlers in BuildPipelineView/bpp.jelly
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
basil
reviewed
Nov 6, 2024
...main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
Outdated
Show resolved
Hide resolved
basil
reviewed
Nov 8, 2024
| @@ -62,13 +63,14 @@ | |||
| <j:if test="${hasBuildPermission}"> | |||
| <div class="icon-container"> | |||
| <j:if test="${from.isProjectParameterized()}"> | |||
| <span class="pointer" onclick="buildPipeline.fillDialog('${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec', 'Starts the pipeline with parameters')"> | |||
| <span class="bpp-trigger-pipeline-parameterized-params" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters" style="display: none" /> | |||
There was a problem hiding this comment.
Why the need for a different element to hold the data attributes? Is it not simpler to put them on the element on the next line?
There was a problem hiding this comment.
Got it - I made the changed and tested that it is working. I'll note all things things for future PR to avoid bloating the DOM.
Thank you!
yaroslavafenkin
approved these changes
Nov 12, 2024
.../au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
Outdated
Show resolved
Hide resolved
…peline/BuildPipelineView/bpp-trigger-pipeline.js Co-authored-by: Yaroslav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73961
Manually tested and is working correctly.
Testing done
BEFORE CHANGES
AFTER CHANGES
Submitter checklist