Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(scheduler): add SkipDraftPR from lighthouse v0.0.1109 #956

Merged
merged 7 commits into from
Apr 19, 2024
Merged

chore(scheduler): add SkipDraftPR from lighthouse v0.0.1109 #956

merged 7 commits into from
Apr 19, 2024

Conversation

JordanGoasdoue
Copy link
Contributor

@JordanGoasdoue JordanGoasdoue commented Apr 3, 2024 •
edited
Loading

@jenkins-x-bot
Copy link
Contributor

Hi @JordanGoasdoue. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@JordanGoasdoue JordanGoasdoue changed the title build(deps): allow to upgrade lighouse-client to v0.0.1109 chore(scheduler): add SkipDraftPR from lighthouse v0.0.1109 Apr 3, 2024
@JordanGoasdoue JordanGoasdoue force-pushed the build-deps-lighthouse-client branch 3 times, most recently from 454a30f to fbc6d45 Compare April 3, 2024 11:28
@JordanGoasdoue JordanGoasdoue mentioned this pull request Apr 3, 2024
Merged
@JordanGoasdoue JordanGoasdoue force-pushed the build-deps-lighthouse-client branch from fbc6d45 to a2d0b5c Compare April 3, 2024 11:44
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JordanGoasdoue JordanGoasdoue force-pushed the build-deps-lighthouse-client branch from a2d0b5c to b9e1f96 Compare April 5, 2024 13:19
@tomhobson
Copy link
Contributor

/ok-to-test

@JordanGoasdoue JordanGoasdoue marked this pull request as draft April 17, 2024 15:26
@JordanGoasdoue JordanGoasdoue force-pushed the build-deps-lighthouse-client branch 3 times, most recently from 9dd9f56 to 49399ee Compare April 17, 2024 16:40
@JordanGoasdoue JordanGoasdoue force-pushed the build-deps-lighthouse-client branch from 49399ee to 73b3d81 Compare April 17, 2024 16:47
@JordanGoasdoue
Copy link
Contributor Author

/test lint

@JordanGoasdoue JordanGoasdoue force-pushed the build-deps-lighthouse-client branch from 0f6ea02 to 1e97aab Compare April 19, 2024 08:54
@JordanGoasdoue JordanGoasdoue force-pushed the build-deps-lighthouse-client branch from 1e97aab to 88ade1a Compare April 19, 2024 08:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@JordanGoasdoue
Copy link
Contributor Author

/test lint

@JordanGoasdoue
Copy link
Contributor Author

/test pr

@JordanGoasdoue
Copy link
Contributor Author

/retest

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [956]: [Method Not Allowed]

@JordanGoasdoue JordanGoasdoue marked this pull request as ready for review April 19, 2024 11:05
@jenkins-x-bot jenkins-x-bot merged commit 4afb995 into jenkins-x-plugins:main Apr 19, 2024
8 of 9 checks passed
@JordanGoasdoue JordanGoasdoue deleted the build-deps-lighthouse-client branch April 19, 2024 11:06
This was referenced Apr 19, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhobson tomhobson tomhobson approved these changes

Assignees
No one assigned
Labels
approved ok-to-test size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanGoasdoue @jenkins-x-bot @tomhobson