Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat allow skip draft prs #953

Closed
wants to merge 6 commits into from
Closed

Feat allow skip draft prs #953

wants to merge 6 commits into from

Conversation

JordanGoasdoue
Copy link
Contributor

@JordanGoasdoue JordanGoasdoue commented Feb 1, 2024

⚠️ needs:

name: Regenerate the source code
on:
  schedule:
    # run a bit before midnight when go deps change
    - cron: '0 23 * * *'
  • We should then have this kind of changes:
--- a/pkg/plugins/config.go
+++ b/pkg/plugins/config.go
@@ -309,6 +309,8 @@ type Trigger struct {
 	// ElideSkippedContexts makes trigger not post "Skipped" contexts for jobs
 	// that could run but do not run.
 	ElideSkippedContexts bool `json:"elide_skipped_contexts,omitempty"`
+	// SkipDraftPR when enabled, skips triggering pipelines for draft PRs, unless /ok-to-test is added.
+	SkipDraftPR bool `json:"skip_draft_pr,omitempty"`
 }

Once lighthouse-client is updated:

  • We need to update go.mod with latest lighthouse-client using the needed parameter

@JordanGoasdoue JordanGoasdoue marked this pull request as draft February 1, 2024 19:52
@jenkins-x-bot
Copy link
Contributor

Hi @JordanGoasdoue. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tomhobson
You can assign the PR to them by writing /assign @tomhobson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@JordanGoasdoue JordanGoasdoue closed this by deleting the head repository Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants