chore: make golangci-lint run pass

pkg/cmd/apply/apply.go

@@ -60,7 +60,7 @@ func NewCmdApply() (*cobra.Command, *Options) {
 		Short:   "Performs a GitOps regeneration and apply on a cluster git repository",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/condition/condition.go

@@ -54,7 +54,7 @@ func NewCmdCondition() (*cobra.Command, *Options) {
 		Short:   "Runs a command if the condition is true",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			o.Args = args
 			err := o.Run()
 			helper.CheckErr(err)

pkg/cmd/copy/copy.go

@@ -64,7 +64,7 @@ func NewCmdCopy() (*cobra.Command, *Options) {
 		Short:   "Copies resources (by default confimaps) with the given selector or name from a source namespace to a destination namespace",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName, rootcmd.BinaryName, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/gc/activities/activities.go

@@ -96,7 +96,7 @@ func NewCmdGCActivities() (*cobra.Command, *Options) {
 		Short:   "garbage collection for PipelineActivity resources",
 		Long:    cmdLong,
 		Example: cmdExample,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/gc/gc.go

@@ -14,7 +14,7 @@ func NewCmdGC() *cobra.Command {
 	command := &cobra.Command{
 		Use:   "gc",
 		Short: "Commands for garbage collecting resources",
-		Run: func(command *cobra.Command, args []string) {
+		Run: func(command *cobra.Command, _ []string) {
 			err := command.Help()
 			if err != nil {
 				log.Logger().Errorf(err.Error())

pkg/cmd/gc/jobs/jobs.go

@@ -59,7 +59,7 @@ func NewCmdGCJobs() (*cobra.Command, *Options) {
 		Aliases: []string{"job"},
 		Long:    cmdLong,
 		Example: cmdExample,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/gc/pods/pods.go

@@ -50,7 +50,7 @@ func NewCmdGCPods() (*cobra.Command, *Options) {
 		Aliases: []string{"pod"},
 		Long:    cmdLong,
 		Example: cmdExample,
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/git/clone/clone.go

@@ -48,7 +48,7 @@ func NewCmdGitClone() (*cobra.Command, *Options) {
 		Short:   "Clones the cluster git repository using the URL, git user and token from the Secret",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/git/get/get.go

@@ -72,7 +72,7 @@ func NewCmdGitGet() (*cobra.Command, *Options) {
 		Short:   "Gets a file from a git repository or environment git repository",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/git/git.go

@@ -15,7 +15,7 @@ func NewCmdGit() *cobra.Command {
 	command := &cobra.Command{
 		Use:   "git",
 		Short: "Commands for working with Git",
-		Run: func(command *cobra.Command, args []string) {
+		Run: func(command *cobra.Command, _ []string) {
 			err := command.Help()
 			if err != nil {
 				log.Logger().Errorf(err.Error())

pkg/cmd/git/merge/merge.go

@@ -73,7 +73,7 @@ func NewCmdGitMerge() (*cobra.Command, *Options) {
 		Short:   "Merge a number of SHAs into the HEAD of the main branch",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/git/setup/setup.go

@@ -103,7 +103,7 @@ func NewCmdGitSetup() (*cobra.Command, *Options) {
 		Short:   "Sets up git to ensure the git user name and email is setup",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/hash/hash.go

@@ -47,7 +47,7 @@ func NewCmdHashAnnotate() (*cobra.Command, *Options) {
 		Short:   "Annotates the given files with a hash of the given source files for ConfigMaps/Secrets",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helm/build/build.go

@@ -51,7 +51,7 @@ func NewCmdHelmBuild() (*cobra.Command, *Options) {
 		Short:   "Builds and lints any helm charts",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helm/escape/escape.go

@@ -41,7 +41,7 @@ func NewCmdEscape() (*cobra.Command, *Options) {
 		Short:   "Escapes any {{ or }} characters in the YAML files so they can be included in a helm chart",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helm/helm.go

@@ -15,7 +15,7 @@ func NewCmdHelm() *cobra.Command {
 	command := &cobra.Command{
 		Use:   "helm",
 		Short: "Commands for working with helm charts",
-		Run: func(command *cobra.Command, args []string) {
+		Run: func(command *cobra.Command, _ []string) {
 			err := command.Help()
 			if err != nil {
 				log.Logger().Errorf(err.Error())

pkg/cmd/helm/mirror/mirror.go

@@ -64,7 +64,7 @@ func NewCmdMirror() (*cobra.Command, *Options) {
 		Short:   "Creates a helm mirror ",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helm/release/release.go

@@ -113,7 +113,7 @@ func NewCmdHelmRelease() (*cobra.Command, *Options) {
 		Short:   "Performs a release of all the charts in the charts folder",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helm/step_helm_template.go

@@ -62,7 +62,7 @@ func NewCmdHelmTemplate() (*cobra.Command, *TemplateOptions) {
 		Short:   "Generate the kubernetes resources from a helm chart",
 		Long:    helmTemplateLong,
 		Example: fmt.Sprintf(helmTemplateExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helmfile/add/add.go

@@ -50,7 +50,7 @@ func NewCmdHelmfileAdd() (*cobra.Command, *Options) {
 		Short:   "Adds a chart to the local 'helmfile.yaml' file",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helmfile/deletecmd/delete.go

@@ -53,7 +53,7 @@ func NewCmdHelmfileDelete() (*cobra.Command, *Options) {
 		Short:   "Deletes a chart from the helmfiles in one or all namespaces",
 		Long:    cmdLong,
 		Example: cmdExample,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, _ []string) error {
 			return o.Run()
 		},
 	}

pkg/cmd/helmfile/helmfile.go

@@ -20,7 +20,7 @@ func NewCmdHelmfile() *cobra.Command {
 		Use:     "helmfile",
 		Short:   "Commands for working with helmfile",
 		Aliases: []string{"helmfiles"},
-		Run: func(command *cobra.Command, args []string) {
+		Run: func(command *cobra.Command, _ []string) {
 			err := command.Help()
 			if err != nil {
 				log.Logger().Errorf(err.Error())

pkg/cmd/helmfile/move/move.go

@@ -77,7 +77,7 @@ func NewCmdHelmfileMove() (*cobra.Command, *Options) {
 		Short:   "Moves the generated template files from 'helmfile template' into the right gitops directory",
 		Long:    namespaceLong,
 		Example: fmt.Sprintf(namespaceExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helmfile/report/report.go

@@ -83,7 +83,7 @@ func NewCmdHelmfileReport() (*cobra.Command, *Options) {
 		Short:   "Generates a markdown report of the helmfile based deployments in each namespace",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helmfile/resolve/resolve.go

@@ -90,7 +90,7 @@ func NewCmdHelmfileResolve() (*cobra.Command, *Options) {
 		Short:   "Resolves any missing versions or values files in the helmfile.yaml file from the version stream",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helmfile/status/status.go

@@ -72,7 +72,7 @@ func NewCmdHelmfileStatus() (*cobra.Command, *Options) {
 		Short:   "Updates the git deployment status after a release",
 		Long:    statusLong,
 		Example: fmt.Sprintf(statusExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helmfile/structure/structure.go

@@ -48,7 +48,7 @@ func NewCmdHelmfileStructure() (*cobra.Command, *Options) {
 		Short:   "Runs 'helmfile structure' on the helmfile in specified directory which will split in to multiple helmfiles based around namespace",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/helmfile/validate/validate.go

@@ -40,7 +40,7 @@ func NewCmdHelmfileValidate() (*cobra.Command, *Options) {
 		Short:   "Validates helmfile.yaml against a jx canonical tree of helmfiles",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/image/image.go

@@ -80,7 +80,7 @@ func NewCmdUpdateImage() (*cobra.Command, *Options) {
 		Short:   "Updates images in the kubernetes resources from the version stream",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},
@@ -195,7 +195,7 @@ func (o *Options) modifyImages(node *yaml.RNode, filePath, jsonPath string, name
 }
 
 // resolveImage resolves the given container image from the version stream
-func (o *Options) resolveImage(image string, names []string, filePath string) (string, error) {
+func (o *Options) resolveImage(image string, _ []string, _ string) (string, error) {
 	resolver := o.VersionStreamer.Resolver
 	if resolver == nil {
 		return "", errors.Errorf("cannot resolve image %s as no VersionResolver configured", image)

pkg/cmd/ingress/ingress.go

@@ -48,7 +48,7 @@ func NewCmdUpdateIngress() (*cobra.Command, *Options) {
 		Short:   "Updates Ingress resources with the current ingress domain",
 		Long:    ingressLong,
 		Example: fmt.Sprintf(ingressExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/jenkins/add/add.go

@@ -59,7 +59,7 @@ func NewCmdJenkinsAdd() (*cobra.Command, *Options) {
 		Short:   "Adds a new Jenkins server to the git repository",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/jenkins/jenkins.go

@@ -13,7 +13,7 @@ func NewCmdJenkins() *cobra.Command {
 	command := &cobra.Command{
 		Use:   "jenkins",
 		Short: "Commands for working with Jenkins GitOps configuration",
-		Run: func(command *cobra.Command, args []string) {
+		Run: func(command *cobra.Command, _ []string) {
 			err := command.Help()
 			if err != nil {
 				log.Logger().Errorf(err.Error())

pkg/cmd/jenkins/jobs/jobs.go

@@ -80,7 +80,7 @@ func NewCmdJenkinsJobs() (*cobra.Command, *Options) {
 		Short:   "Generates the Jenkins Jobs helm files",
 		Long:    cmdLong,
 		Example: fmt.Sprintf(cmdExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/kpt/kpt.go

@@ -13,7 +13,7 @@ func NewCmdKpt() *cobra.Command {
 	command := &cobra.Command{
 		Use:   "kpt",
 		Short: "Commands for working with kpt packages",
-		Run: func(command *cobra.Command, args []string) {
+		Run: func(command *cobra.Command, _ []string) {
 			err := command.Help()
 			if err != nil {
 				log.Logger().Errorf(err.Error())

pkg/cmd/kpt/recreate/recreate.go

@@ -50,7 +50,7 @@ func NewCmdKptRecreate() (*cobra.Command, *Options) {
 		Short:   "Recreates the kpt packages in the given directory",
 		Long:    kptLong,
 		Example: fmt.Sprintf(kptExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/kpt/update/update.go

@@ -77,7 +77,7 @@ func NewCmdKptUpdate() (*cobra.Command, *Options) {
 		Short:   "Updates any kpt packages installed in a sub directory",
 		Long:    kptLong,
 		Example: fmt.Sprintf(kptExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/kustomize/kustomize.go

@@ -58,7 +58,7 @@ func NewCmdKustomize() (*cobra.Command, *Options) {
 		Short:   "Generates a kustomize layout by comparing a source and target directories",
 		Long:    splitLong,
 		Example: fmt.Sprintf(splitExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},
@@ -187,7 +187,7 @@ func (o *Options) createOverlay(srcNode, targetNode *yaml.RNode, path string) (*
 	if overlay != nil {
 		count := 0
 		// lets verify we don't only contain mandatory fields
-		err = walkMappingNodes(overlay, "", func(node *yaml.Node, jsonPath string) error {
+		err = walkMappingNodes(overlay, "", func(_ *yaml.Node, jsonPath string) error {
 			if jsonPath != "" && jsonPath != "metadata" && stringhelpers.StringArrayIndex(mandatoryFields, jsonPath) < 0 {
 				if count == 0 {
 					fmt.Printf("path %s has non mandatory path %s\n", path, jsonPath)

pkg/cmd/lint/lint.go

@@ -44,7 +44,7 @@ func NewCmdLint() (*cobra.Command, *Options) {
 		Short:   "Lints the gitops files in the file system",
 		Long:    splitLong,
 		Example: fmt.Sprintf(splitExample, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/namespace/namespace.go

@@ -58,7 +58,7 @@ func NewCmdUpdateNamespace() (*cobra.Command, *Options) {
 		Short:   "Updates all kubernetes resources in the given directory to the given namespace",
 		Long:    namespaceLong,
 		Example: fmt.Sprintf(namespaceExample, rootcmd.BinaryName, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/patch/patch.go

@@ -59,7 +59,7 @@ func NewCmdPatch() (*cobra.Command, *Options) {
 		Short:   "Patches the given resources",
 		Long:    annotateLong,
 		Example: fmt.Sprintf(annotateExample, rootcmd.BinaryName, rootcmd.BinaryName),
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/plugin/get/get.go

@@ -38,7 +38,7 @@ func NewCmdPluginGet() (*cobra.Command, *Options) {
 		Long:    cmdLong,
 		Example: cmdExample,
 		Aliases: []string{"list", "ls"},
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			err := o.Run()
 			helper.CheckErr(err)
 		},

pkg/cmd/plugin/plugin.go

@@ -13,7 +13,7 @@ func NewCmdPlugin() *cobra.Command {
 	command := &cobra.Command{
 		Use:   "plugin",
 		Short: "Commands for working with plugins",
-		Run: func(command *cobra.Command, args []string) {
+		Run: func(command *cobra.Command, _ []string) {
 			err := command.Help()
 			if err != nil {
 				log.Logger().Errorf(err.Error())