Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract for info from Jenkinsfile and support different layout #544

Merged

Conversation

jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented Dec 31, 2024

Extract full platform information from Jenkinsfile and detect default values according to https://github.com/jenkins-infra/pipeline-library (including useContainerAgent or forkCount)

The only missing is the 'jenkinsVersion' that some plugin decide to override instead of using the default from the pom. I will add it on an other PR

This is also some preparation for #531 in order to keep the current config but migrate to new format. Or adding, removing JDK. Or removing extra jenkinsVersion or limit matrix size (for example 2 or 3 if necessary) to save compute resource

For example

buildPlugin()

will have JDK8 on Linux and Windows

Or

buildPlugin(
   jdkVersions: [21, 17]
)

Will have Java 17 and 21 on Linux and Windows

This is some preparation to convert to the "new" format

buildPlugin(
  configurations: [
        [platform: 'linux', jdk: 21],
        [platform: 'windows', jdk: 17],
  ]
)

Testing done

Mainly automated tests

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jonesbusy jonesbusy force-pushed the featuer/extract-from-jdkVersions branch 7 times, most recently from 35bee4a to e323edb Compare December 31, 2024 15:20
@jonesbusy jonesbusy force-pushed the featuer/extract-from-jdkVersions branch from e323edb to ec2fd6d Compare December 31, 2024 16:22
@jonesbusy jonesbusy marked this pull request as ready for review December 31, 2024 16:41
@jonesbusy jonesbusy added the enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Dec 31, 2024
@jonesbusy jonesbusy merged commit a176bfd into jenkins-infra:main Dec 31, 2024
16 checks passed
@jonesbusy jonesbusy deleted the featuer/extract-from-jdkVersions branch December 31, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant