Skip to content

Commit

Permalink
Apply suggestions from code review from @darxriggs
Browse files Browse the repository at this point in the history
  • Loading branch information
oleg-nenashev authored Aug 28, 2019
1 parent 7ccbf03 commit 5a1e71c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,11 @@ and it may not work for other use-cases.
** It is also possible to use a `buildPlugin.recommendedConfigurations()` method to get recommended configurations for testing.
Note that the recommended configuration may change over time,
and hence your CI may break if the new recommended configuration is not compatible

* `timeout`: (default: `60`) - the number of minutes for build timeout, cannot be bigger than 180, i.e. 3 hours.
[source,groovy]
----
buildPlugin(/*...*/, configurations: [
[ platform: "linux", jdk: "8"],
buildPluginWithGradle(/*...*/, configurations: [
[ platform: "linux", jdk: "8" ],
[ platform: "windows", jdk: "8"],
])
----
Expand Down
1 change: 0 additions & 1 deletion vars/buildPluginWithGradle.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<p>
<b>Usage.</b> The method can be used in the same way as <code>buildPlugin()</code> for Maven projects.
See the documentation in the README of the Pipeline Library repository.
Some parameters may not be supported at the moment, see the Pipeline code.
</p>

<!--
Expand Down

0 comments on commit 5a1e71c

Please sign in to comment.