chore: separated updatecli pipeline

[lemeurherve]

Needs jenkins-infra/kubernetes-management#3855

Ref: jenkins-infra/helpdesk#2778

[lemeurherve]

Corresponding builds: https://infra.ci.jenkins.io/job/updatecli/job/packer-images/view/change-requests/job/PR-606/

[dduportal]

That is a good idea, but you can't merge "as it": this PR break the whole updatecli for this repository, because it changes the environment in which updatecli was executed before so it could, or could not, break things.

The current main branch currently executes updatecli inside a VM agent which label is linux-amd64-docker:

• Top-level agent directive (e.g. default agent):

  packer-images/Jenkinsfile_k8s

  Line 64 in 302702d

  label "linux-amd64-docker"

• No agent directive in the Side Task "top level" stage:

  packer-images/Jenkinsfile_k8s

  Lines 75 to 149 in 302702d

  	stage('Side Tasks') {
  	environment {
  	DRYRUN = "${env.BRANCH_IS_PRIMARY ? 'false' : 'true'}"
  	}
  	parallel {
  	stage('Packer Init') {
  	steps {
  	// Call the initializing function once for the default agent
  	script {
  	packerInitPlugins()
  	}
  	}
  	}
  	stage('GC on AWS us-east-2') {
  	agent {
  	kubernetes {
  	yaml podAgentDefinition
  	}
  	}
  	environment {
  	AWS_ACCESS_KEY_ID = credentials('packer-aws-access-key-id')
  	AWS_SECRET_ACCESS_KEY = credentials('packer-aws-secret-access-key')
  	AWS_DEFAULT_REGION = 'us-east-2'
  	}
  	steps {
  	catchError(buildResult: 'SUCCESS', stageResult: 'FAILURE') {
  	sh './cleanup/aws.sh'
  	sh './cleanup/aws_images.sh 1 dev'
  	sh './cleanup/aws_images.sh 7 staging'
  	sh './cleanup/aws_images.sh 60 prod'
  	sh './cleanup/aws_snapshots.sh'
  	}
  	}
  	}
  	stage('GC on Azure') {
  	agent {
  	kubernetes {
  	yaml podAgentDefinition
  	}
  	}
  	environment {
  	PACKER_AZURE = credentials('packer-azure-serviceprincipal')
  	}
  	steps {
  	catchError(buildResult: 'SUCCESS', stageResult: 'FAILURE') {
  	sh 'az login --service-principal -u "$PACKER_AZURE_CLIENT_ID" -p "$PACKER_AZURE_CLIENT_SECRET" -t "$PACKER_AZURE_TENANT_ID"'
  	sh 'az account set -s "$PACKER_AZURE_SUBSCRIPTION_ID"'
  	sh './cleanup/azure.sh'
  	}
  	}
  	}
  	stage('Updatecli') {
  	steps {
  	catchError(buildResult: 'SUCCESS', stageResult: 'FAILURE') {
  	script {
  	// TODO: Implement https://github.com/jenkins-infra/pipeline-library/issues/518 to allow using the updatecli() library function
  	withCredentials([
  	usernamePassword(
  	credentialsId: 'github-app-updatecli-on-jenkins-infra',
  	usernameVariable: 'USERNAME_VALUE', // Setting this variable is mandatory, even if of not used when the credentials is a githubApp one
  	passwordVariable: 'UPDATECLI_GITHUB_TOKEN'
  	)
  	]) {
  	sh 'updatecli version'
  	sh 'updatecli diff --values ./updatecli/values.yaml --config ./updatecli/updatecli.d'
  	if (env.BRANCH_IS_PRIMARY) {
  	sh 'updatecli apply --values ./updatecli/values.yaml --config ./updatecli/updatecli.d'
  	}
  	}
  	}
  	}
  	}
  	}
  	}
  	}

• No agent directive in the updatecli stage:

  packer-images/Jenkinsfile_k8s

  Lines 126 to 145 in 302702d

  	stage('Updatecli') {
  	steps {
  	catchError(buildResult: 'SUCCESS', stageResult: 'FAILURE') {
  	script {
  	// TODO: Implement https://github.com/jenkins-infra/pipeline-library/issues/518 to allow using the updatecli() library function
  	withCredentials([
  	usernamePassword(
  	credentialsId: 'github-app-updatecli-on-jenkins-infra',
  	usernameVariable: 'USERNAME_VALUE', // Setting this variable is mandatory, even if of not used when the credentials is a githubApp one
  	passwordVariable: 'UPDATECLI_GITHUB_TOKEN'
  	)
  	]) {
  	sh 'updatecli version'
  	sh 'updatecli diff --values ./updatecli/values.yaml --config ./updatecli/updatecli.d'
  	if (env.BRANCH_IS_PRIMARY) {
  	sh 'updatecli apply --values ./updatecli/values.yaml --config ./updatecli/updatecli.d'
  	}
  	}
  	}
  	}

Also, don't forget that the updatecli() pipeline library method takes care of spawning its own pod agent (default image is https://github.com/jenkins-infra/pipeline-library/blob/9e0f0a2f09a7c91b26824e706a8963598b685742/vars/updatecli.groovy#L10, you can change it)

=> There was a good reason to NOT use the pipeline library before (the comment points to an issue :) )
=> Proposal: use the same pipeline code as before , but in the new pipeline for this PR to work.
And/or implement the feature request in the shared library.

=> both case needs you to use agent { label ... } to spin up a VM with Docker inside otherwise you break https://github.com/jenkins-infra/packer-images/blob/main/updatecli/updatecli.d/docker-ce.yaml

[dduportal]

Suggested change

	docker { image 'jenkinsciinfra/helmfile:2.5.92' }
	label "linux-amd64-docker"

This updatecli process requires a Docker Engine, which means it requires a VM.