-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated screenshot for the user guide documentation of the kubernetes plugin using Jenkins #7598
Updated screenshot for the user guide documentation of the kubernetes plugin using Jenkins #7598
Conversation
…ation to manage jenkins" This reverts commit e525070.
… into update-screenshots
…es-plugin config using Jenkins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks very much for the update @yashpal2104, the updated screenshots look good on the page, and if anything the kubernetes-cloud
screenshot reduces the size on the page.
I am requesting changes because the original misplaced screenshots are still being added here and need to be removed. Once they are removed and no longer part of the PR I will approve.
|
||
== Using Jenkins Agents | ||
== Using Jenkins Agentsgit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
== Using Jenkins Agentsgit | |
== Using Jenkins Agents |
Removal of undesired text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will do that thanks for your help I really appreciate it
Hope I have done all the things right this time |
…es-plugin config using Jenkins
Hi @yashpal2104 thanks very much for all the work on this, everything looks good this time around. The only thing I wanted to point out, and sorry for not noticing it sooner, is that in the screenshot for the Jenkins dashboard, it does show your name up in the right hand corner. Would you be able to update your name so that it is something generic like "Administrator" and retake the screenshot with the updated name? We would want to keep everything generalized/anonymous in this sort of situation. |
All right |
…ugin' into updated-screenshot-kubernetes-plugin
@kmartens27 final update, thinking of submitting a new PR for #7525 using credentials updated screenshots |
Fixed #7529 and correctly added the images to the correct location of image directory, to update the screenshots for the user guide of the kubernetes-plugin using Jenkins.