Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated screenshot for the user guide documentation of the kubernetes plugin using Jenkins #7598

Conversation

yashpal2104
Copy link
Contributor

@yashpal2104 yashpal2104 commented Oct 11, 2024

Fixed #7529 and correctly added the images to the correct location of image directory, to update the screenshots for the user guide of the kubernetes-plugin using Jenkins.

@yashpal2104 yashpal2104 requested a review from a team as a code owner October 11, 2024 03:28
@yashpal2104 yashpal2104 changed the title Updated screenshot kubernetes plugin Updated screenshot for the user guide documentation of the kubernetes plugin using Jenkins Oct 11, 2024
Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much for the update @yashpal2104, the updated screenshots look good on the page, and if anything the kubernetes-cloud screenshot reduces the size on the page.

I am requesting changes because the original misplaced screenshots are still being added here and need to be removed. Once they are removed and no longer part of the PR I will approve.


== Using Jenkins Agents
== Using Jenkins Agentsgit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
== Using Jenkins Agentsgit
== Using Jenkins Agents

Removal of undesired text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will do that thanks for your help I really appreciate it

@yashpal2104
Copy link
Contributor Author

Hope I have done all the things right this time

@kmartens27
Copy link
Contributor

Hi @yashpal2104 thanks very much for all the work on this, everything looks good this time around. The only thing I wanted to point out, and sorry for not noticing it sooner, is that in the screenshot for the Jenkins dashboard, it does show your name up in the right hand corner. Would you be able to update your name so that it is something generic like "Administrator" and retake the screenshot with the updated name? We would want to keep everything generalized/anonymous in this sort of situation.

@yashpal2104
Copy link
Contributor Author

All right

@yashpal2104
Copy link
Contributor Author

yashpal2104 commented Oct 11, 2024

@kmartens27 final update, thinking of submitting a new PR for #7525 using credentials updated screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI screenshots in Jenkins documentation
2 participants