-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hapi-fhir service to docker-compose.yml #76
Conversation
Warning Rate limit exceeded@medchedli has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 37 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughA new service named Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…figuration settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- docker-compose.yml (1 hunks)
Additional context used
yamllint
docker-compose.yml
[error] 81-81: duplication of key "image" in mapping
(key-duplicates)
[error] 82-82: duplication of key "ports" in mapping
(key-duplicates)
[error] 84-84: duplication of key "networks" in mapping
(key-duplicates)
[error] 86-86: duplication of key "volumes" in mapping
(key-duplicates)
[error] 88-88: duplication of key "healthcheck" in mapping
(key-duplicates)
Additional comments not posted (1)
docker-compose.yml (1)
64-80
: LGTM! The addition of thehapi-fhir
service looks good.The configuration of the
hapi-fhir
service aligns with the PR objective and includes the necessary settings such as image, port mapping, network, volume, environment variables, and health check.The past review comment about adding the flag to enable IPS within the instance has been addressed by setting the
HAPI_FHIR_IPS_ENABLED
environment variable totrue
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This pull request adds the hapi-fhir service to the docker-compose.yml file. The hapi-fhir service is configured with the image "jembi/hapi:v7.0.3-wget" and is exposed on port 8081. It is also added to the "smart-health-links-portal-network" network and has a volume mounted for data persistence.
Summary by CodeRabbit
New Features
hapi-fhir
, enhancing the application's capabilities.Improvements
hapi-fhir
service to ensure reliability.