Fix/docker image build for production #52
Conversation
Reverting a code regression which was causing the production build to fail. Nextjs routes doesnt support export of unknown fields in route files
WalkthroughThe changes involve significant updates to the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .env (1 hunks)
- docker-compose.yml (2 hunks)
- src/infrastructure/clients/prisma.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- src/infrastructure/clients/prisma.ts
Additional context used
Gitleaks
.env
11-11: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Additional comments not posted (3)
.env (1)
11-11: False positive:KEYCLOAK_CLIENT_SECRETis stored securely.The static analysis hint from Gitleaks has flagged the
KEYCLOAK_CLIENT_SECRETvalue as a potential generic API key. However, this appears to be a false positive in this case.The
KEYCLOAK_CLIENT_SECRETis a sensitive value used for authenticating with Keycloak, and it is appropriate to store it securely in the.envfile, which should not be committed to version control. Therefore, the current handling of this value is correct.Tools
Gitleaks
11-11: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
docker-compose.yml (2)
16-16: Verify the port change has been tested and documented.The change to map the internal port 3000 to the external port 3080 for the
appservice looks good. This will help avoid potential conflicts with other services or applications that might be using port 3000.Please ensure that:
- The application has been tested to work correctly with this new port mapping.
- The port change has been documented, including updating any relevant README files, configuration guides, or deployment instructions.
53-53: Verify the port change has been tested, documented, and environment variable updated.The change to map the internal port 8080 to the external port 8082 for the
keycloakservice looks good. This will help free up port 8080 for other uses or services.Please ensure that:
- The keycloak service has been tested to work correctly with this new port mapping.
- The port change has been documented, including updating any relevant README files, configuration guides, or deployment instructions.
Additionally, consider updating the
KC_HOSTNAME_PORTenvironment variable to match the new external port:environment: KC_HOSTNAME: localhost - KC_HOSTNAME_PORT: 8080 + KC_HOSTNAME_PORT: 8082 KC_HOSTNAME_STRICT_BACKCHANNEL: false
There was a problem hiding this comment.
Actionable comments posted: 4
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .env (1 hunks)
Additional context used
Gitleaks
.env
10-10: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
Additional comments not posted (10)
.env (10)
2-2: LGTM!The modification to the
PRISMA_FIELD_ENCRYPTION_HASH_SALTenvironment variable, replacing the placeholder value with an actual hash salt, is necessary and appropriate.
3-3: LGTM!The addition of the
POSTGRES_DBenvironment variable, set topostgres, is necessary for configuring the PostgreSQL database.
4-4: LGTM!The addition of the
POSTGRES_USERenvironment variable, set topostgres, is necessary for configuring the PostgreSQL database.
6-6: LGTM!The addition of the
EXTERNAL_URLenvironment variable, set tohttp://localhost:3001, is necessary for configuring the application's external URL.
7-7: LGTM!The addition of the
KEYCLOAK_ADMINenvironment variable, set toadmin, is necessary for configuring the Keycloak admin user.
9-9: LGTM!The addition of the
KEYCLOAK_CLIENT_IDenvironment variable, set to"nextjs", is necessary for configuring the Keycloak client ID.
11-11: LGTM!The addition of the
KEYCLOAK_ISSUERenvironment variable, set to"http://localhost:8082/realms/shlp", is necessary for configuring the Keycloak issuer URL.
12-12: LGTM!The addition of the
NEXTAUTH_URLenvironment variable, set to"http://localhost:3000", is necessary for configuring the NextAuth.js URL.
14-14: LGTM!The addition of the
NEXT_CONTAINER_KEYCLOAK_ENDPOINTenvironment variable, set to"http://localhost:8082", is necessary for configuring the Keycloak endpoint for the Next.js container.
15-15: LGTM!The addition of the
NEXT_LOCAL_KEYCLOAK_URLenvironment variable, set to"http://localhost:8082", is necessary for configuring the local Keycloak URL for Next.js.
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Style