Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit review #17

Merged
merged 101 commits into from
Dec 27, 2023
Merged

Audit review #17

merged 101 commits into from
Dec 27, 2023

Conversation

sargue
Copy link
Collaborator

@sargue sargue commented Dec 27, 2023

No description provided.

@sargue
fix ARD-#1
fe3d9f8
@sargue
added E2E tests instructions
248a634
@sargue
added unit tests using Ragger
208e3cc
@sargue
fix ARD-#3
eb58e6c
@sargue
remove warnings
40b5ba0
@sargue
remove AES included library, use SDK functions
c5c397f
@sargue
remove NXT references
ed965f4
@sargue
added pragma once to include files
8b359fd
@sargue
fix type mismatch
b59f9b6
@sargue
remove unused icons
3565cd6
@sargue
extract parse code to file, refactor magic numbers
3028f2d
@sargue
update Copyright
b3b7beb
@sargue
refactor magic numbers
ccac8c4
@sargue
improve code consistency
52957fa
@sargue
refactor long functions
9b8c1ea
@sargue
added tests
569dd93
@sargue
support for testing Nano S Plus
ddb5349
@sargue
updated CI workflow
0ed1558
@sargue
Ci fixes (#12)
f429c43 
* updated workflows
* restore mandatory listvariants target
* use nanox icon for nanos2
@sargue
missing include
65d6515
@sargue
move SDK code to new standard_app SDK
0255e93
@sargue
fix icons location
ab2a3df
@sargue
Merge pull request #13 from jelurida-dev/audit_fixes
36c471d 
Audit fixes, refactors, new Ragger tests, new workflows.
@sargue
refactor to extract UI code
c04e98c
@sargue
refactor to global UI callbacks
67afdf6
@sargue
stax support
b0ed5da
@sargue
added stax ragger tests
cdc465d
@sargue
enable stax on workflows
42f1f0e
@sargue
one more workflow for stax
1793609
@sargue
switch to gif icons
b534bf5
sargue and others added 29 commits October 19, 2023 14:38
@sargue
fix ARD-#7 type confusion
c096035
@sargue
fix ARD-#8 sensitive information clearing
dc669d7
@sargue
fix ARD-#9 add null protection
6123557
@sargue
add buffer size protection
4661322
@sargue
commit txnTypeLists.c as it rarely changes
bd5fe1a
@sargue
use more secure explicit_bzero instead of memset
711512b
@sargue
adjust Makefile to commited txnTypeLists.c
8cd928d
@sargue
refactor p1InitContinueCommon
348d32e
@sargue
more magic numbers refactor
ac721da
@sargue
code style
c615ad0
@sargue
parseMainTxnData refactoring
726c7a2
@sargue
fix codeql warnings
16b0639
@sargue
refactor referenced_tx support
9633e2d
@sargue
fix asset order attachment support
293a6db
@sargue
replace generic fields with union for tx attachments
d2d1911
@sargue
refactored the optional UI windows as an array
2702f48
@sargue
added STAX to CodeQL checks
b8f582c
@sargue
fix CodeQL warning
47d132f
@sargue
remove infinite loop
ac8076e
@sargue
added recommended volatile for variables inside try/catch
42a1934
@sargue
update README
2a3c042
@sargue
added notes about custom EC-KCDSA signing algorithm
ee749b1
@sargue
added workflows manifest file
74655ec
@sgliner-ledger
[auto]: add PR template
7f86268
@sargue
remove review screen
7501308
@sargue
handle crypto library return values
7b5db66
@sargue
ignore python virtual env
99527d5
@sargue
code style
1d64443
@sargue
Merge pull request #16 from LedgerHQ/develop
9ac821d 
[auto]: add PR template
@sargue sargue merged commit b8ee73a into master Dec 27, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sargue @sgliner-ledger