Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate apikeys to React #6390

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Migrate apikeys to React #6390

wants to merge 10 commits into from

Conversation

viown
Copy link
Member

@viown viown commented Dec 16, 2024

Changes

  • Migrates the dashboard api keys page to React + TS SDK
  • Add an onClick listener to ButtonElement similar to IconButtonElement

Issues

@viown viown requested a review from a team as a code owner December 16, 2024 11:56
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Dec 16, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 817b59b
Status ✅ Deployed!
Preview URL https://bdec4e14.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@viown viown added the cleanup Cleanup of legacy code or code smells label Dec 16, 2024
thornbill
thornbill reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also migrate the page to using MUI components?

src/apps/dashboard/routes/_asyncRoutes.ts Outdated Show resolved Hide resolved
@viown
Copy link
Member Author

viown commented Jan 7, 2025

Updated look with mui:
image

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viown @jellyfin-bot @thornbill