#6248 Improvement: Set foundation to improve migrate-to-typescript efficiency #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| /** | ||
| * Class that manages the queue of SyncPlay. | ||
| */ | ||
| class QueueCore { | ||
| private manager: null | Manager; | ||
| private lastPlayQueueUpdate: null | ApiClientPlayMessageData; | ||
| private playlist: any[]; |
There was a problem hiding this comment.
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
Suggestion(s) available:
Suggested change
| private playlist: any[]; | |
| private playlist: unknown[]; |
Suggested change
| private playlist: any[]; | |
| private playlist: never[]; |
| return Helper.translateItemsForPlayback(apiClient, result.Items, { | ||
| ids: itemIds, | ||
| serverId: serverId | ||
| }).then((items) => { | ||
| }).then((items: any[]) => { |
There was a problem hiding this comment.
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
Suggestion(s) available:
Suggested change
| }).then((items: any[]) => { | |
| }).then((items: unknown[]) => { |
Suggested change
| }).then((items: any[]) => { | |
| }).then((items: never[]) => { |
|
|
||
| /** | ||
| * Class that manages the SyncPlay group selection menu. | ||
| */ | ||
| class GroupSelectionMenu { | ||
| private syncPlayEnabled: boolean; | ||
| private SyncPlay: any; |
There was a problem hiding this comment.
Unexpected any. Specify a different type. @typescript-eslint/no-explicit-any
Suggestion(s) available:
Suggested change
| private SyncPlay: any; | |
| private SyncPlay: unknown; |
Suggested change
| private SyncPlay: any; | |
| private SyncPlay: never; |
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/lt/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/ar/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/fa/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/zh_Hans/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/pt/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/fa/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/pt_PT/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/pt/
Co-authored-by: Bill Thornton <[email protected]>
* stylelint-codeguide v1.0.2 * stylelint-scss v6.10.0
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/fr/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/pt_PT/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/pt/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/it/
Translation: Jellyfin/Jellyfin Web Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-web/sr/
…--typescript-convert
|
|
Ran into rebasing issues after a bad merge. Re-opened with a clean branch here: #6440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #6248.
src/index.jsxtosrc/index.tsxand declareswebSettings.d.tsand another modeule to serve as an example of how the migration to typescript can be done iterativelyIssues