-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add missing context menu items #1951
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File download are just ported legacy code, might want to fix it Also context menu aren't properly showing it on home screen
Removed the fallback clipboard copy code since it looks like the whole project is targeting es2022. Also cleanup/restructure some i18n strings
…ri app Added the following packages: - tauri-apps/api - tauri_plugin_upload (handle stream download) Both clipboard and file download should now use their respective native API. Clipboard use either the navigator or tauri clipboard API File download use the <a> download trick or use the downloader from tauri_plugin_upload since using stream download would be better so it does not eat memory. Added a new task to handle file download announcement (Tauri only) Maybe add a way to announce error to the task manager. Also cleaned up old legacy code for file download.
…ve Tauri API for Tauri app" This half reverts commit 6c706cd. Only remove the Tauri part since it would be better to make separate PR for it.
Also did some refactoring
More inline with jf-web since they did not include it
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 16, 2023
This was referenced Apr 16, 2023
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 23, 2023
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 23, 2023
Split from the following PR: jellyfin#1951
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 23, 2023
Split from: jellyfin#1951 Ignore the lint error since the Refresh metadata PR should fix it.
ferferga
pushed a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 27, 2023
* Split from: jellyfin#1951 * Also add CanDelete to API requests
ferferga
pushed a commit
that referenced
this pull request
Apr 27, 2023
* Split from: #1951 * Also add CanDelete to API requests
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 28, 2023
Split from the following PR: jellyfin#1951
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 28, 2023
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 28, 2023
ferferga
pushed a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 28, 2023
ferferga
pushed a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 28, 2023
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 28, 2023
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 29, 2023
Split from: jellyfin#1951 fix: invalid i18n key hiding the Identify action feat: add `ExternalUrls` fields to userLibraries store This should be able to show the prefilled data on the home screen now
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
Apr 29, 2023
Split from the following PR: jellyfin#1951
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
May 3, 2023
Split from the following PR: jellyfin#1951
ferferga
pushed a commit
that referenced
this pull request
May 4, 2023
Split from: #1951 fix: invalid i18n key hiding the Identify action feat: add `ExternalUrls` fields to userLibraries store This should be able to show the prefilled data on the home screen now
noaione
added a commit
to noaione/jellyfin-vue
that referenced
this pull request
May 5, 2023
Split from the following PR: jellyfin#1951
ferferga
pushed a commit
to noaione/jellyfin-vue
that referenced
this pull request
Jun 20, 2023
Split from the following PR: jellyfin#1951
ferferga
pushed a commit
to noaione/jellyfin-vue
that referenced
this pull request
Aug 15, 2023
Split from the following PR: jellyfin#1951
ferferga
pushed a commit
to noaione/jellyfin-vue
that referenced
this pull request
Aug 16, 2023
Split from the following PR: jellyfin#1951
ferferga
pushed a commit
that referenced
this pull request
Aug 16, 2023
Split from the following PR: #1951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented almost every context menu item that are missing from JF-Vue
Added the following item:
And maybe implement this:
Also Fix #1950
I didn't know that much Vue so any feedback is appreciated.