Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite PlaybackManager with SDK #4455

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Feb 13, 2025

Now that #4438 is merged I could finally finish this one.

Changes

  • Rewrite PlaybackManager in Kotlin using our "new" SDK
  • Removes a lot of custom code for manually creating streams that was no longer in use
    • Half of it was for the previous external player code 🙃
  • Removes the last remaining API calls using the old java apiclient
    • Upcoming PR will remove it entirely!!!!!
  • Rewrite device profile with same sub-optimal behavior using the SDK's profile builder (much more readable now!)
  • Fix max bitrate not always set correctly in device profile
  • Fix playback reporting in legacy player shouldn't be cancellable
    • This would sometimes cause the "playback stopped" message to not arrive on the server

Be aware there may be some bugs, I've done some initial testing and everything seems to be working. Some things that will need some further testing: multi-version video, live TV, strm files, external subtitles, switching subtitle/video tracks, remuxing (was unable to trigger non-transcode remux myself).

Additional changes will be done in separate PR's so we can move forward removing the apiclient.

Issues

@nielsvanvelzen nielsvanvelzen added enhancement New feature or request playback Issue related to media playback sdk-migration To fix this we need to migrate some code to the new SDK labels Feb 13, 2025
@nielsvanvelzen nielsvanvelzen added this to the v0.19.0 milestone Feb 13, 2025
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@nielsvanvelzen nielsvanvelzen merged commit e33d85c into jellyfin:master Feb 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request playback Issue related to media playback sdk-migration To fix this we need to migrate some code to the new SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants