Trust user added CA certificates #4397
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -49,7 +49,8 @@ | |||
| android:largeHeap="true" | |||
| android:supportsRtl="true" | |||
| android:theme="@style/Theme.Jellyfin" | |||
| android:usesCleartextTraffic="true"> | |||
| android:usesCleartextTraffic="true" | |||
Check warning
Code scanning / Android Lint
Attribute unused on older versions Warning
| @@ -49,7 +49,8 @@ | |||
| android:largeHeap="true" | |||
| android:supportsRtl="true" | |||
| android:theme="@style/Theme.Jellyfin" | |||
| android:usesCleartextTraffic="true"> | |||
| android:usesCleartextTraffic="true" | |||
| android:networkSecurityConfig="@xml/network_security_config"> | |||
Check warning
Code scanning / Android Lint
Attribute unused on older versions Warning
| @@ -0,0 +1,9 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <network-security-config> | |||
| <base-config cleartextTrafficPermitted="true"> | |||
Check warning
Code scanning / Android Lint
Insecure Base Configuration Warning
| <base-config cleartextTrafficPermitted="true"> | ||
| <trust-anchors> | ||
| <certificates src="system" /> | ||
| <certificates src="user" /> |
Check warning
Code scanning / Android Lint
Allowing User Certificates Warning
nielsvanvelzen
requested changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trust user added CA certificates. I added a CA root certificate on Fire TV stick, and the Amazon Silk Browser trusts the certificate but Jellyfin app shows "Unable to connect" when using the https URL
Changes
Trust both system (default behavior) and also user added CA root certificates
Issues