Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Video Player Documentation - Move AV1 from Video to Container Section #1416

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Jan 30, 2025

This should be under containers not video. Confusing since AVi vs AV1. Added a note for the Apple SOC that first added HWA AV1 decoding as this should correspond with AVKit's ability to use it.

Pre-AV1 Decoders, I tested, and AV1 works but is VERY choppy so defaulting this to disabled is still the right move!

Resolves: #1415

…Section

This should be under containers not video. Confusing since AV**i** vs AV**1**. Added a note for the Apple SOC that first added HWA AV1 decoding as this should correspond with AVKit's ability to use it.

Pre-AV1 Decoders, I tested, and AV1 works but is VERY choppy so defaulting this to disabled is still the right move!
@JPKribs JPKribs added the documentation Improvements or additions to documentation label Jan 30, 2025
@JPKribs JPKribs assigned JPKribs and unassigned JPKribs Jan 30, 2025
@JPKribs JPKribs requested a review from LePips January 30, 2025 16:32
Documentation/players.md Outdated Show resolved Hide resolved
Co-authored-by: Ethan Pippin <[email protected]>
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast change! And thank you to @Jojolam44 for reporting.

@LePips LePips merged commit 21cf786 into main Jan 30, 2025
4 checks passed
@JPKribs JPKribs deleted the playerAV1 branch January 30, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in « player difference » documentation ?
2 participants