Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot update CLA: trivial (deps): Bump nowsecure/nowsecure-action from 1.0.2 to 4.0.1 #4

Merged

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Oct 22, 2024

Bumps nowsecure/nowsecure-action from 1.0.2 to 4.0.1.

Release notes

Sourced from nowsecure/nowsecure-action's releases.

v4

Version 4 of the NowSecure GitHub Action.

See the README for additional details.

v3

Version 3 of the NowSecure GitHub Action.

See the README for additional details.

v2

Version 2 of the NowSecure GitHub Action.

See the README for additional details.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

CLA: trivial

(deps): Bump nowsecure/nowsecure-action

Bumps [nowsecure/nowsecure-action](https://github.com/nowsecure/nowsecure-action) from 1.0.2 to 4.0.1.
- [Release notes](https://github.com/nowsecure/nowsecure-action/releases)
- [Commits](nowsecure/nowsecure-action@3b439db...901b53b)

---
updated-dependencies:
- dependency-name: nowsecure/nowsecure-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Author

dependabot bot commented on behalf of github Oct 22, 2024

Dependabot tried to add @jefferyq2/committers as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/jefferyq2/openssl/pulls/4/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the jefferyq2/openssl repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

Copy link
Author

dependabot bot commented on behalf of github Oct 22, 2024

The following labels could not be found: dependencies, cla: trivial, approval: review pending, approval: otc review pending.

jefferyq2 pushed a commit that referenced this pull request Nov 6, 2024
Running the x509_req_test with address sanitizer shows a memory leak:

==186455==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 53 byte(s) in 1 object(s) allocated from:
    #0 0x3ffad5f47af in malloc (/lib64/libasan.so.8+0xf47af) (BuildId: 93b3d2536d76f772a95880d76c746c150daabbee)
    #1 0x3ffac4214fb in CRYPTO_malloc crypto/mem.c:202
    #2 0x3ffac421759 in CRYPTO_zalloc crypto/mem.c:222
    #3 0x100e58f in test_mk_file_path test/testutil/driver.c:450
    #4 0x1004671 in test_x509_req_detect_invalid_version test/x509_req_test.c:32
    #5 0x100d247 in run_tests test/testutil/driver.c:342
    #6 0x10042e3 in main test/testutil/main.c:31
    openssl#7 0x3ffaad34a5b in __libc_start_call_main (/lib64/libc.so.6+0x34a5b) (BuildId: 461b58df774538594b6173825bed67a9247a014d)
    openssl#8 0x3ffaad34b5d in __libc_start_main@GLIBC_2.2 (/lib64/libc.so.6+0x34b5d) (BuildId: 461b58df774538594b6173825bed67a9247a014d)
    openssl#9 0x1004569  (/root/openssl/test/x509_req_test+0x1004569) (BuildId: ab6bce0e531df1e3626a8f506d07f6ad7c7c6d57)
SUMMARY: AddressSanitizer: 53 byte(s) leaked in 1 allocation(s).

The certFilePath that is obtained via test_mk_file_path() must be freed when
no longer used.

While at it, make the certFilePath variable a local variable, there is no need
to have this a global static variable.

Fixes: openssl@7d2c0a4

Signed-off-by: Ingo Franzki <[email protected]>

Reviewed-by: Dmitry Belyavskiy <[email protected]>
Reviewed-by: Neil Horman <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from openssl#24715)
@jefferyq2 jefferyq2 merged commit ad8b60e into master Nov 6, 2024
190 of 205 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/nowsecure/nowsecure-action-4.0.1 branch November 6, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant