Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding yaml support #79

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PersonligaPersson
Copy link

I've added basic support for writing YAML in the nsprc configuration file. This was requested in issue #70.

The basic idea was to use the package yaml to parse the .nsprc file. I've ran this code with the the equivalent nsprc files
1070404: active: true notes: my note expiry: '2022-05-30'

and

{ "1070404": { "active": true, "notes": "These are my notes", "expiry": '2022-05-30' } }

on a project I'm working on which produced the same output.

Let me know if there are any changes needed for the PR to be accepted. Thanks!

@jeemok
Copy link
Owner

jeemok commented Aug 17, 2024

hey @PersonligaPersson sorry for the long due response. YAML support sounds amazing! Happy to merge this PR, would you be able to resolve the conflicts (I have just updated the repo after 2 years)? and I think it would be great to include a small test to try parsing a YAML file, so we can secure this feature and get it tested in the CI. Cheers!

@jeemok jeemok self-assigned this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants