Only cache results that are not empty

jeakfrw · Nov 14, 2019 · 55c1f8b · 55c1f8b
1 parent 1de21af
commit 55c1f8b
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/main/java/de/fearnixx/jeak/service/teamspeak/UserService.java b/src/main/java/de/fearnixx/jeak/service/teamspeak/UserService.java
@@ -100,10 +100,13 @@ private List<IUser> computeIfNotCached(Predicate<IUser> matchBy, Supplier<List<I
             }).orElseGet(() -> {
                 logger.trace("Computing result for search: {}", searchHint);
                 List<IUser> users = getBy.get();
-                CachedUserResult result =
-                        new CachedUserResult(users, LocalDateTime.now().plusSeconds(USR_CACHE_TTL));
-                userCache.add(result);
-                return result.getUsers();
+                if (!users.isEmpty()) {
+                    CachedUserResult result =
+                            new CachedUserResult(users, LocalDateTime.now().plusSeconds(USR_CACHE_TTL));
+                    userCache.add(result);
+                    users = result.getUsers();
+                }
+                return users;
             });
         }
     }