Allow required to overwrite required_by_default #817
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the README.md file, the
required_by_default
option is described as:But schemas that explicitly set the
required
property do not overwrite therequired_by_default
option as advertised, so they are always required (even withrequired = false
using JSON Schema 3 syntax orrequired = []
using JSON Schema 4 syntax).The issue can be demonstrated with this code snippet which does not pass validation: