Add multiselect support to enum_titles #583
Conversation
| for(i=0; i<e.length; i++) { | ||
| // If the sanitized value is different from the enum value, don't include it | ||
| if(this.sanitize(e[i]) !== e[i]) continue; | ||
|
|
||
| this.option_keys.push(e[i]+""); | ||
| this.option_titles.push(eTitles[i]+""); |
There was a problem hiding this comment.
Looks like there is mix of tab/space indentation in these few line additions.
There was a problem hiding this comment.
How do I see the conflicts? Can I fix it on the current pull request?
There was a problem hiding this comment.
Update: I changed the tab/space indentation with the github site manual edit. Tell me If I can do anything else to advance the merge.
There was a problem hiding this comment.
I'm not actually a maintainer so I'm not sure what else to do to advance this. I was just trying to be helpful since i'm hoping this gets merged.
As far as conflicts, I had noticed that github is indicating that it can't auto-merge these changes. It might simply be because your changes are off an older version of master. You can update your fork to the latest master https://help.github.com/articles/syncing-a-fork/
|
I'm also looking for support for this. Would be great if this got merged once the indentation was fixed and conflicts resolved with current master. |
No description provided.