-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button/placeholder translations and a complete german localization #353
base: master
Are you sure you want to change the base?
Conversation
Thanks, this is really cool! My only worry is that you have Grunt including all language files in the build, which will increase the size of the library for everyone, even those just using a single language. It's not a huge problem with just two languages, but it can get out of control quickly. I'll look at how some other libraries handle this, but I'm thinking one of these ways could work:
Both ways have their pros and cons. |
Mhh, i think the second option is the better one. Other libs like jQuery UI have it that way. I can change the PR to this if you want. |
👍 for second option |
…l concatenated into the main jsoneditor(.min).js)
Hello, @jdorn: after reading your comment a third time I'm not sure if I understood you correctly, but what I did now is the following:
<script src="./dist/jsoneditor.min.js"></script>
<script src="./dist/languages/de.min.js"></script>
<script>
JSONEditor.defaults.language = 'de';
// ...
</script> It's no problem to prefix the language files with Best regards, |
Could this please be merged? This would be very useful. |
Any news on this? Should I resolve the merge conflicts? |
+1 |
1 similar comment
+1 |
Not sure if this helps this pull request, but I changed the localization to conform to the current release
|
@jdorn ping - any chance you can merge this any time soon? This would be really helpful to me if merged. |
Hello Jeremy,
thanks for your very cool editor 👍
For our project we needed a version with localized button captions, so I've created a feature branch on our fork, which you might want to integrate. If you have any suggestions for improvements they are very welcome.
I've seen #196, but it's not doing the whole translation (e.g. no button texts and no placeholder translation).
Best regards,
Benjamin