Make conditionally as CommonJS module as per issue #309 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good morning, I would like to add that it would be nice to also support AMD loaders. Personally I think the best way is to use UMD as per https://github.com/umdjs/umd/blob/master/returnExports.js Best regards, |
|
+1 |
|
Any reason this hasn't been pulled in yet? While I can install the fork via NPM, it doesn't have the compiled, |
|
Hello there, any progress for this pull request? It's been over a year already... |
|
Hello, Kindly wondering if there is a reason if this hasn't been merged (or even responded to in the last 2 1/4 years). Seems like a layup that would make a lot of people's lives a little easier... especially considering the repo is available through npm. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.