Clarify that schema options can be applied at the schema level or global... #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bal level and some at the editor instance level.
|
I'm not sure if I agree with these changes. I can take another pass over that part of the documentation and see if I can make it a bit clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... level and some at the editor instance level.
I thought the README ought to follow the pattern in the other sections and mention the possibility of using the schema options on the editor instance (even though I know the options are also documented there), at least for the two which are available. Not sure if it was deliberate that
hiddenwas not allowed on editor instances, but I mentioned this limitation as well.And I thought it should be clarified that the options could be placed on the schema.